Replace all f-strings to use .format#756
Merged
Conversation
JCantu248
requested review from
Matthew-Grayson,
aloftus23,
cduhn17,
nickviola,
rapidray12 and
schmelz21
as code owners
Contributor
|
Looks like the pylint is failing in the Backend Pipeline / Test (pull_request) I guess they want you to use %s with logger instead of format. Not sure why |
schmelz21
approved these changes
Jan 17, 2025
aloftus23
approved these changes
Jan 17, 2025
Contributor
aloftus23
left a comment
aloftus23
left a comment
There was a problem hiding this comment.
All looks good!
Also went through the full local build process and tested all frontend pages. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
Replace all Python f-strings to use the .format() method for formatting.
💭 Motivation and context
In the interest of security against injection attacks, all Python f-strings have been replaced with their equivalent with the format() method.
🧪 Testing
Tested by rebuilding the entire project, and running the entire PyTest suite.
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.